Bug/58555 reminder mail not sent in case more than 15 notifications are to be reported about #17021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulferts
changed the title
machisuji
deleted the
bug/58555-reminder-mmail-not-sent-in-case-more-than-15-notifications-are-to-be-reported-about
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/58555
What are you trying to accomplish?
The notification_path is not defined in the context of the template being rendered. It will thus result in an hard error and this means that the mail is not sent at all. I haven't been able to figure out why the path is not defined but it needs to be the
notifications_urlin any case since the full url needs to be available as the link is followed from the mail client.A second thing that was changed is the concurrency key although no errors have been reported about that. But with the way it was defined before, only one of multiple users sharing the same name could have a
Mail::ReminderJobscheduled at the same time. The reason for this is that sometimes the user object is passed in. On it,to_swill be called to determine the concurrency_key. If two people share the same name, then adding the job for the second user will be prevented. This is changed by using the id of the user object instead.Merge checklist